[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51411: NS port cleanups
From: |
Po Lu |
Subject: |
bug#51411: NS port cleanups |
Date: |
Sun, 31 Oct 2021 18:34:15 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Alan Third <alan@idiocy.org> writes:
> I think what you'll need to do is union the two rectangles and then
> clip to that, rather than clipping them both separately. That will
> then provide the same clipping as the NSClipRect code does.
I meant to say that DPSrectclip intersects (IOW, behaves just as
NSClipRect does). Unless that's incorrect, I think what I'm doing right
now should work fine.
> I must be failing to communicate well, we keep seeming to
> misunderstand each other.
It could be my problem as well: my reading comprehension is nowhere near
as good as I would rather it be. Thanks a lot for tolerating it.
> You still need to focus, however you don't have to clip when you
> focus.
After I unfocus here:
/* Draw box if not done already. */
if (!s->for_overlaps && !box_drawn_p && s->face->box != FACE_NO_BOX)
ns_dumpglyphs_box_or_relief (s);
-> ns_unfocus (s->f);
I make sure to focus again if an overhang might be drawn again (inside
if (s->prev) and if (s->next)), like so:
/* Draw surrounding overhangs. */
if (s->prev)
{
-> ns_focus (s->f, NULL, 0);
struct glyph_string *prev;
There is, of course, a matching unfocus. Is that not adequate, and if
so, could you please explain how?
Thanks for the feedback, I really appreciate it.
- bug#51411: NS port cleanups, Po Lu, 2021/10/26
- bug#51411: NS port cleanups, Alan Third, 2021/10/26
- bug#51411: NS port cleanups, Po Lu, 2021/10/26
- bug#51411: NS port cleanups, Alan Third, 2021/10/27
- bug#51411: NS port cleanups, Po Lu, 2021/10/27
- bug#51411: NS port cleanups, Alan Third, 2021/10/28
- bug#51411: NS port cleanups, Po Lu, 2021/10/28
- bug#51411: NS port cleanups, Alan Third, 2021/10/31
- bug#51411: NS port cleanups,
Po Lu <=
- bug#51411: NS port cleanups, Po Lu, 2021/10/31
- bug#51411: NS port cleanups, Alan Third, 2021/10/31
- bug#51411: NS port cleanups, Po Lu, 2021/10/31
- bug#51411: NS port cleanups, Po Lu, 2021/10/31
- bug#51411: NS port cleanups, Alan Third, 2021/10/31
- bug#51411: NS port cleanups, Po Lu, 2021/10/31