[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#51362: python font-lock-mode in emacs 28 seems broken

From: Dario Gjorgjevski
Subject: bug#51362: python font-lock-mode in emacs 28 seems broken
Date: Thu, 11 Nov 2021 09:04:01 +0100


Thanks a lot for the report and the reproducer, and sorry for the regression that my patch introduced.
It has been a while since I wrote any Python, so I did not notice it.

What seems to be happening is that python-font-lock-assignment-matcher is giving up too early.
Replacing its definition by
(defun python-font-lock-assignment-matcher (regexp)
  "Font lock matcher for assignments based on REGEXP.
Return nil if REGEXP matched within a `paren' context (to avoid,
e.g., default values for arguments or passing arguments by name
being treated as assignments) or is followed by an '=' sign (to
avoid '==' being treated as an assignment."
  (lambda (limit)
    (let ((res nil))
      (while (and (setq res (re-search-forward regexp limit t))
                  (or (python-syntax-context 'paren)
                      (equal (char-after (point)) ?=))))
should fix the issue.
Would you be able to give it a try?

Unfortunately some issues still remain, all of which can be illustrated by a file containing the following code:
CustomInt = int

def f(x: CustomInt) -> CustomInt:
    y = x + 1
    ys: Sequence[CustomInt] = [y, y + 1]
    res: CustomInt = sum(ys) + 1
    return res
When such a file is first opened:
These are caused by the type hints (in the case of 1. — by the type hints in the function's signature).
I am not sure how one would fix them.

Regarding reverting the patch: It can be done easily, but the previous code had even more bugs happening around type hints.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]