[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51368: 29.0.50; `cl-case' should error on incorrect use
From: |
Philipp Stephani |
Subject: |
bug#51368: 29.0.50; `cl-case' should error on incorrect use |
Date: |
Fri, 12 Nov 2021 20:34:13 +0100 |
Am Mo., 1. Nov. 2021 um 14:31 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> > Yes, but the problem only arises if the user wants to match the symbol
> > `quote' plus exactly one other value. That should already be
> > exceedingly rare, and can be trivially rewritten by swapping the two
> > values (i.e. write (foo quote) instead of (quote foo)). So I think
> > issuing a warning or error for that case is worth it.
>
> I think we're getting into slightly muddy waters, but I think I agree --
> a warning here is (much more) likely to be helpful than not.
>
Ok, I've attached two patches that implement these suggestions.
0001-Signal-an-error-if-a-fallback-case-is-misplaced-Bug-.patch
Description: Binary data
0002-Have-cl-case-warn-about-suspicious-cases-Bug-51368.patch
Description: Binary data