[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51832: Piping unicode text in `shell-command'
From: |
Alan Third |
Subject: |
bug#51832: Piping unicode text in `shell-command' |
Date: |
Sun, 14 Nov 2021 15:20:14 +0000 |
On Sun, Nov 14, 2021 at 03:28:02PM +0100, Lars Ingebrigtsen wrote:
> Philipp <p.stephani2@gmail.com> writes:
>
> >> That didn't fix the issue for me, I'm afraid -- with that patch, LANG is
> >> still the invalid en_NO.UTF-8 for me.
> >
> > Maybe we should add similar logic as iTerm2
I tried to find how iTerm2 does it. Your search-fu is better than
mine, apparently. :)
> > (https://github.com/gnachman/iTerm2/blob/79aff4d59fd591e7628649bcabe5f27541740bf6/sources/PTYSession.m#L7107):
> > create the locale identifier from language code and country code
> > instead of the current locale identifier,
>
> I think that's what's Macos is returning -- it's just concatenating
> those two codes to get a locale identifier. (Which is wrong, of
> course.)
Yeah, I don't think there's any advantage to building them up
manually.
> > and use setlocale (or better, newlocale) to check whether it's valid,
>
> Yes, that sounds good.
>
> > and fall back to en_US.UTF-8 otherwise?
>
> Hm... I'd rather just leave LANG unset in that case -- it'll probably
> lead to fewer glitches, I think.
I proposed something similar before:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51321#90
but it didn't look like we needed it then. We know better now.
New patch attached.
--
Alan Third
v2-0001-Only-set-LANG-if-the-ID-is-valid.patch
Description: Text document
- bug#51832: Piping unicode text in `shell-command', (continued)
- bug#51832: Piping unicode text in `shell-command', Eli Zaretskii, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Philipp, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Eli Zaretskii, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Lars Ingebrigtsen, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Philipp, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Eli Zaretskii, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Alan Third, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Lars Ingebrigtsen, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Philipp, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Lars Ingebrigtsen, 2021/11/14
- bug#51832: Piping unicode text in `shell-command',
Alan Third <=
- bug#51832: Piping unicode text in `shell-command', Lars Ingebrigtsen, 2021/11/14
- bug#51832: Piping unicode text in `shell-command', Alan Third, 2021/11/16
- bug#51832: Piping unicode text in `shell-command', Daniel MartÃn, 2021/11/14