[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline
From: |
Juri Linkov |
Subject: |
bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers |
Date: |
Sat, 20 Nov 2021 21:17:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> Yep, I already tried `(re-search-forward diff-hunk-header-re)' too,
>> and it works. But still typing TAB on the hunk heading
>> with outline-minor-mode-cycle=t does nothing, whereas typing TAB
>> on the file heading correctly cycles the file diff.
>
> Oh yeah, now I'm seeing the problem. I don't really use outline mode
> daily, so I'm not sure how it's supposed to work, but -- TAB in these
> buffers are bound to diff-hunk-next, and as far as I can tell, outline
> mode has just placed a keymap property on the file headings, not the
> hunk headings.
>
> Or is that the actual bug here? đ I should probably have read the
> entire thread before getting involved.
Actually, âoutline-font-lock-keywordsâ extends the outline regexp
to (concat "^\\(?:" outline-regexp "\\).+"). And indeed,
(re-search-forward (concat "^\\(?:" diff-hunk-header-re "\\).+"))
fails in diff buffers. Don't ask me why outline.el adds ".+"
at the end, I don't know đ¤ To circumvent this idiosyncrasy
for headings in âdescribe-bindingsâ, I had to use a different regexp
in âoutline-minor-mode-highlight-bufferâ (not based on font-lock):
(concat "^\\(?:" outline-regexp "\\).*$")))
where ".+" is replaced with less-strict ".*".
bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/18
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Lars Ingebrigtsen, 2021/11/19
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/19
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Lars Ingebrigtsen, 2021/11/20
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers,
Juri Linkov <=
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Lars Ingebrigtsen, 2021/11/21
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Matthias Meulien, 2021/11/21
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/21
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Matthias Meulien, 2021/11/21
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Matthias Meulien, 2021/11/22
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Matthias Meulien, 2021/11/22
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Lars Ingebrigtsen, 2021/11/24
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/24
bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/21