[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52067: 29.0.50; string-glyph-split halts on certain emoji strings
From: |
Paul Maragakis |
Subject: |
bug#52067: 29.0.50; string-glyph-split halts on certain emoji strings |
Date: |
Wed, 24 Nov 2021 10:15:07 -0500 |
Excellent---and thanks for the explanation!
I confirm that the latest Emacs 29 fixes the bug.
You can close this ticket.
Paul
> On Nov 24, 2021, at 2:30 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Paul Maragakis <paul.maragakis@icloud.com> writes:
>
>> The logic in string-glyph-split expects the first two elements in the result
>> from find-composition-internal to give the start and end of a multibyte
>> grapheme
>> and return nil when there is a regular character at position POS. However,
>> this
>> isn't always the case.
>
> Yup.
>
> Paul Maragakis <paul.maragakis@icloud.com> writes:
>
>> The following code fixes this bug, though there might be better ways
>> to fix it for someone who understands the domain.
>
> Thanks. `find-composition' takes a the LIMIT parameter, and that'll
> make it avoid searching back into the bit of the string that we've
> already handled. So I did that instead in Emacs 29.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
bug#52067: possible fix for string-glyph-split halts on certain emoji strings., Paul Maragakis, 2021/11/23