[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer
From: |
Eli Zaretskii |
Subject: |
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer |
Date: |
Thu, 25 Nov 2021 13:21:02 +0200 |
> Date: Thu, 25 Nov 2021 11:07:44 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org
>
> > Thanks, but I'd prefer a less obscure way of telling whether this is
> > going into *Help* buffers. Is this really the only way?
>
> I agree with you that it's a bit obscure, and I tried to find a better
> way, but couldn't. Someone else might have a better idea. I think
> another possible way would be to query this-command:
>
> (in-help (or (eq major-mode 'help-mode)
> (and this-command
> (where-is-internal this-command help-map t))))
>
> But somehow I find this even less elegant, and I'm less certain about its
> correctness.
It's definitely not more elegant, agreed.
I do hope a better idea emerges. Anybody?
> > Or maybe the mouse-face etc. should not be put as part of
> > substitute-command-keys, but by the Help mode itself, when the text is
> > already in the *Help* buffer? As we use substitute-command-keys more
> > and more, these problems will probably pop up more and more, so maybe we
> > should rethink whether this part is really something it should do.
> >
>
> With this patch it shouldn't happen outside of Help mode anymore.
Yes, but that's somewhat blunt a weapon, I think. My idea was to
maybe let the caller decide whether this is wanted or not, if we are
going to use substitute-command-keys in way more contexts than it was
originally meant to.
- bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, (continued)
- bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Lars Ingebrigtsen, 2021/11/24
- bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Andreas Schwab, 2021/11/24
- bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Po Lu, 2021/11/24
- bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Lars Ingebrigtsen, 2021/11/25
- bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Po Lu, 2021/11/25
- bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Lars Ingebrigtsen, 2021/11/26
- bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Po Lu, 2021/11/26
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Gregory Heytings, 2021/11/25
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Gregory Heytings, 2021/11/25
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Eli Zaretskii, 2021/11/25
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Gregory Heytings, 2021/11/25
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Eli Zaretskii, 2021/11/25
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Gregory Heytings, 2021/11/25
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Eli Zaretskii, 2021/11/26
bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer, Robert Pluim, 2021/11/26