bug#52342: [PATCH] Add Texinfo support for Flymake

[João Távora]

On Tue, Dec 7, 2021 at 11:43 PM João Távora <joaotavora@gmail.com> wrote:

On Tue, Dec 7, 2021 at 11:39 PM Okamsn <okamsn@protonmail.com> wrote:

On 12/7/21 09:23, João Távora wrote:
> Not sure about the eval-when-compile for require.  It was my
> _expression_ that require is always "when compile".
>
> I've unfortunately been a little away from Emacs lately.
>
> João

My understanding is that `eval-when-compile` is used to make sure that
macro definitions are available during compilation and that the
libraries are not loaded when `texinfo.el` is loaded.  The macros in the
patch are `rx`, `cl-loop`, and `flymake-log`.

require is always `eval-and-compile` (sorry if I misled you earlier).

It's OK to use `eval-when-compile` when needing `cl-loop` from `cl-lib`

if _all_ you need form `cl-lib` is indeed macros.

But for flymake, you need the actual runtime things too, right? So

I think plain require is better and simpler

Hmmm, on second thought, it you're planning on relying on

autoloads for ultimate loading lazyness.... Hmm, maybe

you're right...

João