bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#53517: 29.0.50; [PATCH] `eshell-eval-using-options' :preserve-args b


From: Jim Porter
Subject: bug#53517: 29.0.50; [PATCH] `eshell-eval-using-options' :preserve-args breaks :external handling in some cases
Date: Mon, 24 Jan 2022 21:19:52 -0800

On 1/24/2022 5:11 PM, Jim Porter wrote:
(It might be nice to fix that too, but I think it's still useful to
keep the original raw args around unchanged. Improving "-" support
could be done later.)

Actually, I'll do that now. Doing so fixes an issue I found in the implementation of `eshell/cat'. "cat -" should read from stdin (and the Eshell implementation should use the external /bin/cat to do this), but it was getting parsed as "cat", so it erroneously thought there were *no* input files. Previously, `eshell--process-args' saw the "-" and started to look for short options, found none, and then just shrugged and ignored that token entirely.

I also fixed an issue with the first patch where I had some misplaced parens in test/lisp/eshell/esh-opt-tests.el.

Attachment: 0001-Don-t-manipulate-args-in-place-for-eshell-eval-using.patch
Description: Text document

Attachment: 0002-Treat-as-a-positional-arg-in-eshell-eval-using-optio.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]