[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#53638: [PATCH] newsticker better path handling and data storage
From: |
Robert Pluim |
Subject: |
bug#53638: [PATCH] newsticker better path handling and data storage |
Date: |
Mon, 31 Jan 2022 11:23:47 +0100 |
>>>>> On Sun, 30 Jan 2022 19:47:03 +0000, mailj2--- via "Bug reports for GNU
>>>>> Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:
mailj2> The way newsticker currently handles paths involves directly
concating
mailj2> "/", which only works for UNIX systems.
emacs-28 has `file-name-concat' for this very purpose, perhaps you
could respin to use that instead.
mailj2> Additionally, since newsticker uses `prin1-to-string' for storing
mailj2> groups and cache, it should be enforced that `print-level' and
mailj2> `print-length' are set to nil for the operation just as a
precaution (it
mailj2> happened to me that I manually set these once, which resulted in the
mailj2> newsticker cache being corrupted).
OK. It would be good to have a ChangeLog style commit message as well,
see CONTRIBUTE for details. 'C-x 4 a' can help with writing it.
Robert
--