bug#53636: 29.0.50; face-remapping broken on master

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> If we want to solve this cleanly and radically, I'd prefer to break
> the vicious circle by removing the inheritance from basic faces
> altogether.  The basic faces are just that: they aren't supposed to
> inherit from other basic faces.  That would also decouple header-line
> and everything else as a side effect.

OK, you want to change the header-line and mode-line-inactive faces so
that they no longer inherit from the mode-line face?

But they aren't the only basic faces that have this problem --
`tab-line' inherits from `variable-pitch', for instance.

> That's how face-remapping-alist takes its effect.  If you want this to
> work for inherited faces, you must do this for the parent face,
> recursively, before you do it for the face in which you are
> interested.  You want to add the inheritance-chasing loop to basic
> face look up?  I don't.

No, I don't.  I was thinking of altering `face-remap-add-relative' so
that it resolves the faces that inherit instead of leaving it to
redisplay.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no