bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54606: 27.1; next/previous image command in image-mode triggers tram


From: Michael Albinus
Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers
Date: Fri, 01 Apr 2022 09:06:14 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Phil Sainty <psainty@orcon.net.nz> writes:

Hi Phil,

>>> If you want to go *this* direction, there would be a simple change:
>>>                  (equal (file-remote-p dir)
>>>                         (file-remote-p default-directory))
>>> file-remote-p doesn't do anything on wire.
>> I think that sounds like a good change here anyway.
>
> Agreed -- if I'd checked to see what file-remote-p actually
> returned, I would done this myself from the outset.
>
> I've tested this approach in isolation, and it works well
> in my test instance.

So I've pushed this to master.

> I've not yet tested to see whether the `non-essential'
> change is similarly efficient in a newer version with a
> similar session.

It will help for buffers with a broken remote connection. I've pushed
this change as well.

> Lars' suggestion of having these commands NOT checking
> every dired buffer every time also seems very sensible.

>From my pov, this bug could be closed. However, I'll keep it open in
case something else shall be changed, too. But that I won't investigate
myself.

> -Phil

Best regards, Michael.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]