bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#55033: [PATCH] Define indentation behavior for a few more special Sc


From: Eli Zaretskii
Subject: bug#55033: [PATCH] Define indentation behavior for a few more special Scheme forms
Date: Wed, 20 Apr 2022 10:47:22 +0300

> Date: Wed, 20 Apr 2022 09:20:45 +0200
> From: Jean Abou Samra <jean@abou-samra.fr>
> 
> The attached patch defines special indentation for a few more special Scheme
> forms: and-let*, with-syntax, eval-when, and the pattern matching family
> (match, match-lambda, match-let, etc.).

Thanks, but could you perhaps explain the rationale for each change,
so that they could be independently verified?  I find the comment
above this part of code, viz.:

  ;; (put 'begin 'scheme-indent-function 0), say, causes begin to be indented
  ;; like defun if the first form is placed on the next line, otherwise
  ;; it is indented like any other form (i.e. forms line up under first).

too obfuscated to understand the numbers used as the values of this
property; in particular, the interpretation of the numerical value
(zero in the above example) doesn't seem to be explained, at least not
explicitly enough for me to understand it.  I'd love to have that
explained better if possible.

Also, when you say "SRFI 2" in a comment, where in the SRFI 2 document
should one look for the information relevant to the indentation?

> I didn't do copyright assignment, assuming that the patch is trivial enough,
> but let me know if this would be desirable.

This patch can be accepted without a copyright assignment, but if you
intend to contribute to Emacs in the future, I'd encourage you to
start your legal paperwork rolling, so that we could accept your
contributions without any limitations.  If you agree, I will send you
the form to fill and the instructions to email it.

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]