bug#34749: 26.1; `delete-windows-on': (1) doc, (2) bug, (3) bug, (4) candidates

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> In particular, this doc string should say explicitly what happens with a
> prefix arg, including what happens with different kinds of raw prefix
> arg (including, but not limited to, 0).
>
> The doc string should also say that a prefix arg is ignored when the
> condition of the last paragraph applies (dedicated window alone in
> frame, with other frames existing), if that's true.

Eli fixed some of this, and I've now moved the interactive doc up.

> It seems like the interactive behavior is not correct, as well as being
> poorly documented.  It's hard to know just what behavior was intended,
> or what behavior would be best if (as it seems) we still need to design
> this.

I've now mapped all other non-zero interactive prefixes to t (meaning
"only this frame") in Emacs 29.  It was suggested to do further
mappings, but I don't think the other FRAME values are particularly
usable in an interactive form.

> 4. The buffer candidates available for completion (which should also be
> the only buffer names available for entry - see #3) should depend on
> which frames are used, i.e., on the prefix arg or its absence.
>
> You should be presented only with the names of buffers that are actually
> shown in windows on the frames that you've chosen to consider for
> window-deletion.

Makes sense.  I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no