bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#55153: 29.0.50; Implement system_process_attributes on Cygwin


From: Ken Brown
Subject: bug#55153: 29.0.50; Implement system_process_attributes on Cygwin
Date: Wed, 27 Apr 2022 12:45:45 -0400
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1

On 4/27/2022 11:53 AM, Eli Zaretskii wrote:
Date: Wed, 27 Apr 2022 11:16:46 -0400
From: Ken Brown <kbrown@cornell.edu>

+# ifdef CYGWIN
+  /* ttname */
+  strcpy (procfn_end, "/ctty");
+  fd = emacs_open (fn, O_RDONLY, 0);
+  if (fd < 0)
+    nread = 0;
+  else
+    {
+      record_unwind_protect_int (close_file_unwind, fd);
+      nread = emacs_read_quit (fd, procbuf, sizeof procbuf);
+    }
+  /* /proc/<pid>/ctty should always end in newline. */
+  if (0 < nread && procbuf[nread - 1] == '\n')
+    procbuf[nread - 1] = '\0';
+  else
+    procbuf[0] = '\0';
+  attrs = Fcons (Fcons (Qttname, build_string (procbuf)), attrs);

Is what you read from /proc/<pid>/ctty guaranteed to be pure-ASCII
string?

Yes.  It's typically something like "/dev/pty0".

P.S. Doesn't this warrant a NEWS entry?

Revised patch attached, with a NEWS entry.

Ken

Attachment: 0001-Implement-system_process_attributes-on-Cygwin.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]