bug#55732: 29.0.50; Crash when clicking the menu bar on macOS

[Daniel Martín]

This is a regression introduced by commit 
d8adce56a0a9169c3ad6cb6f51fc116f5ccd127c

Steps to reproduce the problem:

emacs -Q
Click on any item in the menu bar.

Expected results:

The menu is displayed correctly.

Actual results:

Emacs crashes with the following stacktrace:

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib                     0x1b30dad98 __pthread_kill + 8
1   libsystem_pthread.dylib                    0x1b310fee0 pthread_kill + 288
2   libsystem_c.dylib                          0x1b3012680 raise + 32
3   emacs                                      0x1008506c8 
terminate_due_to_signal + 200 (emacs.c:458)
4   emacs                                      0x100850ecc emacs_abort + 20 
(sysdep.c:2310)
5   emacs                                      0x100809c68 ns_term_shutdown + 
168 (nsterm.m:5665)
6   emacs                                      0x1006e0bd0 shut_down_emacs + 
328 (emacs.c:2973)
7   emacs                                      0x100850690 
terminate_due_to_signal + 144 (emacs.c:441)
8   emacs                                      0x100706e90 handle_fatal_signal 
+ 16 (sysdep.c:1780)
9   emacs                                      0x100706f0c 
deliver_thread_signal + 124 (sysdep.c:1772)
10  emacs                                      0x100704fe4 
deliver_fatal_thread_signal + 12 (sysdep.c:1792)
11  libsystem_platform.dylib                   0x1b31274a4 _sigtramp + 56
12  libsystem_kernel.dylib                     0x1b3101ecc 
abort_with_payload_wrapper_internal + 104
13  libsystem_kernel.dylib                     0x1b3101e64 abort_with_reason + 
32
14  libobjc.A.dylib                            0x1b2fbcb40 
_objc_fatalv(unsigned long long, unsigned long long, char const*, char*) + 128
15  libobjc.A.dylib                            0x1b2fbcac0 _objc_fatal(char 
const*, ...) + 44
16  libobjc.A.dylib                            0x1b2fbd6f4 
AutoreleasePoolPage::badPop(void*) + 212
17  CoreFoundation                             0x1b319a2b4 
_CFAutoreleasePoolPop + 32
18  Foundation                                 0x1b409037c -[NSAutoreleasePool 
drain] + 140
19  AppKit                                     0x1b607e4c4 
NSSLMGlobalEventHandler + 432
20  HIToolbox                                  0x1bbdeb6c8 
DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 
1084
21  HIToolbox                                  0x1bbdeab4c 
SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, 
HandlerCallRec*) + 356
22  HIToolbox                                  0x1bbdea9dc 
SendEventToEventTargetWithOptions + 44
23  HIToolbox                                  0x1bbfbb23c 
SendItemEvent(MenuSelectData*, unsigned int, MenuData*, unsigned short) + 308
24  HIToolbox                                  0x1bbe85268 
UpdateMenuViewFocus(MenuSelectData*, MenuData*, short, short) + 568
25  HIToolbox                                  0x1bbe801c8 
ViewFocusHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, void*) + 520
26  HIToolbox                                  0x1bbdeb6c8 
DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 
1084
27  HIToolbox                                  0x1bbdeab4c 
SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, 
HandlerCallRec*) + 356
28  HIToolbox                                  0x1bbdea9dc 
SendEventToEventTargetWithOptions + 44
29  HIToolbox                                  0x1bbe62538 
HIView::SendSetFocusPart(short, unsigned char, unsigned char, short*) + 248
30  HIToolbox                                  0x1bbe623a4 
HIView::SetFocusPartInternal(short, unsigned char, unsigned char, short*, 
short, unsigned char, unsigned char) + 116
31  HIToolbox                                  0x1bbe6215c 
HIView::SetFocusPart(short, unsigned char, unsigned char, unsigned int, 
FocusData*) + 240
32  HIToolbox                                  0x1bbe61fa0 HIViewSetFocus + 168
33  HIToolbox                                  0x1bbe847f4 
ChooseItem(MenuSelectData*, Rect const*) + 220
34  HIToolbox                                  0x1bbfba1c8 
TrackMenuCommon(MenuSelectData&, unsigned char*, SelectionData*, MenuResult*, 
MenuResult*) + 1016
35  HIToolbox                                  0x1bbe87054 
MenuSelectCore(MenuData*, Point, double, unsigned int, OpaqueMenuRef**, 
unsigned short*) + 348
36  HIToolbox                                  0x1bbe86e48 
_HandleMenuSelection2 + 416
37  AppKit                                     0x1b5ede964 
_NSHandleCarbonMenuEvent + 300
38  AppKit                                     0x1b5ede744 
_DPSEventHandledByCarbon + 68
39  AppKit                                     0x1b5d40824 
-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 
+ 3280
40  AppKit                                     0x1b5d32250 -[NSApplication run] 
+ 596
41  emacs                                      0x100809e00 -[EmacsApp run] + 
336 (nsterm.m:5718)
42  emacs                                      0x100808a80 ns_select_1 + 968 
(nsterm.m:4718)
43  emacs                                      0x1007c93e0 
wait_reading_process_output + 4324 (process.c:5618)
44  emacs                                      0x1006ea840 kbd_buffer_get_event 
+ 556 [inlined]
45  emacs                                      0x1006ea840 
read_event_from_main_queue + 768 (keyboard.c:2233) [inlined]
46  emacs                                      0x1006ea840 
read_decoded_event_from_main_queue + 768 (keyboard.c:2297) [inlined]
47  emacs                                      0x1006ea840 read_char + 9884 
(keyboard.c:2927)
48  emacs                                      0x1006e6448 read_key_sequence + 
1412 (keyboard.c:9957)
49  emacs                                      0x1006e465c command_loop_1 + 712 
(keyboard.c:1399)
50  emacs                                      0x100773284 
internal_condition_case + 96 (eval.c:1478)
51  emacs                                      0x1006e4380 command_loop_2 + 52 
(keyboard.c:1140)
52  emacs                                      0x100772b60 internal_catch + 88 
(eval.c:1208)
53  emacs                                      0x100850af0 
recursive_edit_1.cold.1 + 80 (keyboard.c:1118)
54  emacs                                      0x1006e3bbc command_loop + 4 
(keyboard.c:1115) [inlined]
55  emacs                                      0x1006e3bbc recursive_edit_1 + 
372 (keyboard.c:727)
56  emacs                                      0x1006e3d4c Frecursive_edit + 
364 (keyboard.c:810)
57  emacs                                      0x1006e3028 main + 9220 
(emacs.c:2488)
58  dyld                                       0x10113908c start + 520