[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55815: [PATCH] bindat: Improve str, strz documentation
From: |
Richard Hansen |
Subject: |
bug#55815: [PATCH] bindat: Improve str, strz documentation |
Date: |
Mon, 6 Jun 2022 19:31:35 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
Thanks for the review. A new revision is attached.
On 6/6/22 06:59, Eli Zaretskii wrote:
I think it is better to say
Unibyte string that is @var{len} bytes long.
Done. I may have gone overboard though -- I did so because there are three
representations that matter:
1. The input string to be packed.
2. The packed output.
3. The result of unpacking.
Right now all three of those are unibyte, but in a future patch I plan on
changing the first to accept unibyte-convertible multibyte input strings.
Our conventions are to leave two spaces between sentences.
Done.
Also, for consistency, I suggest to use "null byte" everywhere, to
avoid potential confusion of non-native English speakers.
Done.
I also fixed a flaw in the previous revision: packing to a fixed-length field
doesn't actually write a null byte if the input is shorter than the field. This
only matters if the caller provided a pre-allocated string that doesn't have
null bytes.
Thanks,
Richard
v2-0001-bindat-Improve-str-strz-documentation.patch
Description: Text Data
OpenPGP_signature
Description: OpenPGP digital signature
- bug#55815: [PATCH] bindat: Improve str, strz documentation, Richard Hansen, 2022/06/05
- bug#55815: [PATCH] bindat: Improve str, strz documentation, Eli Zaretskii, 2022/06/06
- bug#55815: [PATCH] bindat: Improve str, strz documentation,
Richard Hansen <=
- bug#55815: [PATCH] bindat: Improve str, strz documentation, Eli Zaretskii, 2022/06/07
- bug#55815: [PATCH] bindat: Improve str, strz documentation, Stefan Monnier, 2022/06/07
- bug#55815: [PATCH] bindat: Improve str, strz documentation, Richard Hansen, 2022/06/08
- bug#55815: [PATCH] bindat: Improve str, strz documentation, Eli Zaretskii, 2022/06/09