[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help m
From: |
Visuwesh |
Subject: |
bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message |
Date: |
Tue, 14 Jun 2022 23:39:34 +0530 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
[செவ்வாய் ஜூன் 14, 2022 23:32] Visuwesh wrote:
> [செவ்வாய் ஜூன் 14, 2022 20:40] Eli Zaretskii wrote:
>
>>> From: Visuwesh <visuweshm@gmail.com>
>>> Date: Tue, 14 Jun 2022 22:57:48 +0530
>>>
>>> repeat-mode echoes unset keys in the help message since it doesn't check
>>> for non-nil value of command bound to key; will attach patch once I get
>>> the bug number.
>>
>> Thanks, but can you please show a recipe from "emacs -Q", to
>> understand better what problem are you trying to fix?
>
> Sure.
>
> 1. M-x repeat-mode RET.
> 2. C-h n.
> 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
> 4. C-c @ C-n. Notice how the help message still says C-n despite
> being unbound, and when you type C-n the repeat map exits
> contrary to what the message says.
Oh, looks like if I give `define-key' a non-nil REMOVE argument, then
C-n is no longer displayed in the help message.