[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46882: 26.3; Let `dired-omit-mode' match lines, as well as file name
From: |
Drew Adams |
Subject: |
bug#46882: 26.3; Let `dired-omit-mode' match lines, as well as file names |
Date: |
Tue, 21 Jun 2022 14:33:02 +0000 |
> > Its counterpart variable is `dired-omit-files' that is a regexp.
> > Shouldn't the new variable be named with the same naming scheme
> > for consistency? I.e. just `dired-omit-lines'. Even so that
> > it's not just a regexp, but can be a symbol of a function name.
^^^^^^^^^^^^^^^^^^
Ah, so you _didn't_ use the code I sent, which
supports a symbol as a _variable_, whose value
is a regexp. Too bad.
And what kind of function are we talking about?
A function that returns a regexp? A function
that does something else?
> Makes sense; now renamed.
Too bad. Guess that changes this from "done"
to "won't fix".
Guess this is hidden behind your "I've now
pushed to Emacs 29 (with some changes)."
^^^^^^^^^^^^^^^^^
Guess I'll have to keep the original option
`diredp-omit-lines-regexp' around. I was
hoping Emacs would absorb it, so renaming
`diredp-' to `dired-' would suffice.
For your "consistency" maybe you'll now want
to change `dired-omit-files' to also support
a function symbol... I mean, _consistency_,
right?
And while you're at it, for "consistency"
consider renaming `dired-garbage-files-regexp'.
Oh, and add support for it to be a function
symbol... Consistency.
Consistency is a wonderful, hobgoblinny thing.