[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin
From: |
Sean Whitton |
Subject: |
bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin |
Date: |
Thu, 23 Jun 2022 21:40:25 -0700 |
User-agent: |
Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) |
Hello,
On Thu 23 Jun 2022 at 09:18pm -04, Ken Brown wrote:
> diff --git a/lisp/eshell/esh-io.el b/lisp/eshell/esh-io.el
> index 3644c1a18b..1c4131cb07 100644
> --- a/lisp/eshell/esh-io.el
> +++ b/lisp/eshell/esh-io.el
> @@ -276,8 +276,8 @@ eshell-close-target
> ;; If we're redirecting to a process (via a pipe, or process
> ;; redirection), send it EOF so that it knows we're finished.
> ((eshell-processp target)
> - (if (eq (process-status target) 'run)
> - (process-send-eof target)))
> + (while (eq (process-status target) 'run)
> + (process-send-eof target)))
>
> ;; A plain function redirection needs no additional arguments
> ;; passed.
>
> I'm about to go AFK for a few days. If the eshell people agree that something
> like this patch should be installed, please go ahead. I think it would then
> be
> worth re-enabling the extpipe tests on EMBA to see if the problem is fixed
> there
> too.
I'm a bit queasy about an unbounded loop here. Why not just try three
times? Or, better, try twice, and a third time only if we're on a
platform where we know it's needed.
Many thanks for the investigative work.
--
Sean Whitton
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, (continued)
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Ken Brown, 2022/06/17
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Ken Brown, 2022/06/17
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Jim Porter, 2022/06/17
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Ken Brown, 2022/06/18
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Jim Porter, 2022/06/18
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Ken Brown, 2022/06/18
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Jim Porter, 2022/06/18
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Sean Whitton, 2022/06/18
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Ken Brown, 2022/06/19
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Ken Brown, 2022/06/23
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin,
Sean Whitton <=
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Eli Zaretskii, 2022/06/24
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Jim Porter, 2022/06/24
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Sean Whitton, 2022/06/24
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Jim Porter, 2022/06/24
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Eli Zaretskii, 2022/06/25
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Jim Porter, 2022/06/25
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Eli Zaretskii, 2022/06/25
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Lars Ingebrigtsen, 2022/06/26
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Sean Whitton, 2022/06/26
- bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin, Jim Porter, 2022/06/26