bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#56329: 29.0.50; [PATCH] RET at EOB of *Server* (gnus)


From: Lars Ingebrigtsen
Subject: bug#56329: 29.0.50; [PATCH] RET at EOB of *Server* (gnus)
Date: Fri, 01 Jul 2022 12:48:22 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

dick.r.chiang@gmail.com writes:

> +(defsubst gnus-server--server-name (which)
> +  (when-let ((server
> +              (save-excursion
> +                (let (prop)
> +                  (while (and (null (setq prop (get-text-property 
> (point-at-bol) which)))
> +                              (zerop (forward-line -1))))
> +                  prop))))
> +    (symbol-name server)))
> +
>  (defun gnus-server-server-name ()
> -  (let ((server (get-text-property (point-at-bol) 'gnus-server)))
> -    (and server (symbol-name server))))
> +  (gnus-server--server-name 'gnus-server))

This will make commands like `gnus-server-yank-server' fail (you can't
yank a server after the final server), I think?

So this has to be fixed the hard way, like gnus-group-mode does it --
i.e., sprinkle (when (eobp) ...) into the commands where an action on
the final line also makes sense to select the final server.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]