[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effec
From: |
Eli Zaretskii |
Subject: |
bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk) |
Date: |
Sun, 17 Jul 2022 08:57:37 +0300 |
> Date: Sat, 16 Jul 2022 21:52:09 -0400
> From: Richard Hansen <rhansen@rhansen.org>
>
> emacs -Q
> M-: (setq auto-resize-tool-bars 'grow-only) RET
> C-s
>
> The tool bar now shows a ridiculously oversized marine life ring icon on the
> "Help" button, and the height of the tool bar has grown to accommodate the
> icon's size.
>
> C-g
>
> Expected behavior: The tool bar reverts back to how it was before C-s was
> pressed, except its height stays the same.
>
> Actual behavior: The tool bar reverts back to how it was before, including
> reverting to its original height.
I cannot reproduce this because on my system the Help button doesn't
get the "ridiculously oversized marine life ring icon", so the tool
bar doesn't resize. But I see something suspicious in the code which
handles this feature:
if (!NILP (Vauto_resize_tool_bars))
{
bool change_height_p = true; <<<<<<<<<<<<<<<<<<<<<<
AFAIU, that initialization should have been to 'false', not 'true'.
Can you try this on your system and see if such a change gives good
results?
Thanks.
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Richard Hansen, 2022/07/16
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Po Lu, 2022/07/17
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk),
Eli Zaretskii <=
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Eli Zaretskii, 2022/07/17
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Richard Hansen, 2022/07/17
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Po Lu, 2022/07/17
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Richard Hansen, 2022/07/17
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Po Lu, 2022/07/18
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Richard Hansen, 2022/07/18
- bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Po Lu, 2022/07/18
bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk), Lars Ingebrigtsen, 2022/07/17