[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-
From: |
YE |
Subject: |
bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook |
Date: |
Sun, 24 Jul 2022 10:49:33 +0300 |
>> Or maybe adding a defcustom 'diff-whitespace-style' would be a proper
>> solution here?
>
> Since `diff-setup-whitespace' unconditionally sets whitespace-style from
> a hardcoded value, this is the natural fix.
>
>> I started working on such a patch but stuck disliking the probable
>> need in the 'whitespace-style' large ':type' definition duplication.
>
> I think you don't need a duplication. You can reuse an existing type
> definition by looking up the `custom-type` symbol property of an already
> defined option. See e.g. "lisp/eshell/em-cmpl.el" for a few example
> definitions.
Thanks for the advice.
The proposed patch is attached.
0001-Add-new-user-option-diff-whitespace-style.patch
Description: Add user option diff-whitespace-style
- bug#56679: 28.1; whitespace-style cannot be configured for diff-mode via hook, YE, 2022/07/21
- bug#56679: 28.1; whitespace-style cannot be configured for diff-mode via hook, Michael Heerdegen, 2022/07/22
- bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook,
YE <=
- bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook, Lars Ingebrigtsen, 2022/07/24
- bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook, Eli Zaretskii, 2022/07/24
- bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook, Michael Heerdegen, 2022/07/24
- bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook, Eli Zaretskii, 2022/07/25
- bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook, Michael Heerdegen, 2022/07/26
- bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook, YE, 2022/07/26
- bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook, Lars Ingebrigtsen, 2022/07/27