[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option
From: |
Juri Linkov |
Subject: |
bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented |
Date: |
Sun, 24 Jul 2022 19:38:27 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> It's difficult to choose self-descriptive symbols. So we need to have
>> just good enough symbol names, then describe their exact meaning in the
>> documentation.
>
> Then I guess introducing 'inc-no' and 'inc-no-ding' for incremental
> wrapping should do as it preserves the meaning of the existing values.
>
> Just one more question.
>
> Why shouldn't the behaviour of 'no' and 'no-ding' be changed to handle
> incremental searches as well, instead of introducing new values?
Good question. The reason was to maintain "backward-compatibility".
But do we really need to restrict the existing values only to C-s C-s,
and not to incremental commands? In this case here is a new patch:
diff --git a/lisp/isearch.el b/lisp/isearch.el
index 8f480a87d9..ad30b5e514 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2838,6 +2839,9 @@ isearch-search-and-update
isearch-barrier
(1+ isearch-other-end)))))
(isearch-search)
+ (when (and (memq isearch-wrap-pause '(no no-ding))
+ (not isearch-success))
+ (isearch-repeat (if isearch-forward 'forward 'backward)))
))
(isearch-push-state)
(if isearch-op-fun (funcall isearch-op-fun))
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, (continued)
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Arun V, 2022/07/13
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Juri Linkov, 2022/07/13
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Arun V, 2022/07/16
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Arun V, 2022/07/16
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Juri Linkov, 2022/07/17
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Arun V, 2022/07/20
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Juri Linkov, 2022/07/20
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Arun V, 2022/07/21
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Juri Linkov, 2022/07/22
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Arun V, 2022/07/22
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented,
Juri Linkov <=
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Arun V, 2022/07/25
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Arun V, 2022/07/31
- bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented, Juri Linkov, 2022/07/31