[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56682: Fix the long lines font locking related slowdowns
From: |
Po Lu |
Subject: |
bug#56682: Fix the long lines font locking related slowdowns |
Date: |
Tue, 02 Aug 2022 11:01:54 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Gregory Heytings <gregory@heytings.org> writes:
>
> + bool_bf long_line_syntax_ppss_done_p : 1;
Please write a comment for every bitfield in that struct.
> + current_buffer->long_line_syntax_ppss_done_p = 1;
Why not write "true" instead of "1"?
> + CALLN (Ffuncall, intern ("syntax-ppss"), Fpoint_max ());
Why not write this instead:
call2 (Qsyntax_ppss, Fpoint_max ());
of course, with the appropriate DEFSYM added to the right file?
I think calling "intern" with a static string in C code is an example of
lazy programming. At the very least, it unduly wastes cycles.
- bug#56682: Fix the long lines font locking related slowdowns, (continued)
- bug#56682: Fix the long lines font locking related slowdowns, Stefan Monnier, 2022/08/02
- bug#56682: Fix the long lines font locking related slowdowns, Gregory Heytings, 2022/08/02
- bug#56682: Fix the long lines font locking related slowdowns, Stefan Monnier, 2022/08/03
- bug#56682: Fix the long lines font locking related slowdowns, Gregory Heytings, 2022/08/03
- bug#56682: Fix the long lines font locking related slowdowns, Stefan Monnier, 2022/08/03
- bug#56682: Fix the long lines font locking related slowdowns, Gregory Heytings, 2022/08/03
- bug#56682: Fix the long lines font locking related slowdowns, Stefan Monnier, 2022/08/04
- bug#56682: Fix the long lines font locking related slowdowns,
Po Lu <=
bug#56682: Fix the long lines font locking related slowdowns, Stefan Monnier, 2022/08/01
- bug#56682: Fix the long lines font locking related slowdowns, Gregory Heytings, 2022/08/01
- bug#56682: Fix the long lines font locking related slowdowns, Eli Zaretskii, 2022/08/01
- bug#56682: Fix the long lines font locking related slowdowns, Dmitry Gutov, 2022/08/01
- bug#56682: Fix the long lines font locking related slowdowns, Eli Zaretskii, 2022/08/01
- bug#56682: Fix the long lines font locking related slowdowns, Dmitry Gutov, 2022/08/02
- bug#56682: Fix the long lines font locking related slowdowns, Gregory Heytings, 2022/08/02
- bug#56682: Fix the long lines font locking related slowdowns, Eli Zaretskii, 2022/08/02
- bug#56682: Fix the long lines font locking related slowdowns, Gregory Heytings, 2022/08/02
- bug#56682: Fix the long lines font locking related slowdowns, Dmitry Gutov, 2022/08/02