[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51451: image-transform-original has a misleading name
From: |
Stefan Kangas |
Subject: |
bug#51451: image-transform-original has a misleading name |
Date: |
Wed, 14 Sep 2022 09:52:43 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
close 51451 29.1
thanks
Juri Linkov <juri@linkov.net> writes:
>>> image-transform-* commands are modifying the values of
>>> image-transform-* variables.
>>> Would you propose to rename variables as well?
>>
>> I didn't think about that, as the commands are what the user will see.
>> Maybe we should. Do you think it would be a good idea?
>
> At least, currently there is consistency in naming of
> image-transform-* functions and variables. Whether
> selecting such a prefix was a good choice is another question.
>
> But if you see a problem only in the name of image-transform-original,
> then it could be renamed to image-transform-set-original or maybe
> better to image-transform-reset-to-original, i.e. to something more
> descriptive, while keeping the existing name prefix.
>
> PS: renaming to image-transform-reset-to-original will also require
> renaming image-transform-reset to image-transform-reset-to-initial.
Thanks. I've now changed this as you suggest (commit 37fe0cd358).
- bug#51451: image-transform-original has a misleading name,
Stefan Kangas <=