[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#57813: Icon images are non-functional
From: |
Juri Linkov |
Subject: |
bug#57813: Icon images are non-functional |
Date: |
Thu, 15 Sep 2022 22:53:07 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
> Fixed now in 471414fe6b.
Since now images can be displayed in outlines,
here is a patch that adds nice images to outlines
that look like this:
diff --git a/etc/images/outline-close.svg b/etc/images/outline-close.svg
new file mode 100644
index 0000000000..ea9157a5fb
--- /dev/null
+++ b/etc/images/outline-close.svg
@@ -0,0 +1,6 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 20
20">
+<title>outline-close</title>
+<g transform="rotate(-90, 10, 10)">
+<path d="m17.5 4.75-7.5 7.5-7.5-7.5L1 6.25l9 9 9-9z"/>
+</g>
+</svg>
diff --git a/etc/images/outline-open.svg b/etc/images/outline-open.svg
new file mode 100644
index 0000000000..75cf6aff9f
--- /dev/null
+++ b/etc/images/outline-open.svg
@@ -0,0 +1,4 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 20
20">
+<title>outline-open</title>
+<path d="m17.5 4.75-7.5 7.5-7.5-7.5L1 6.25l9 9 9-9z"/>
+</svg>
diff --git a/lisp/emacs-lisp/icons.el b/lisp/emacs-lisp/icons.el
index 93749a3451..ff4f20c207 100644
--- a/lisp/emacs-lisp/icons.el
+++ b/lisp/emacs-lisp/icons.el
@@ -202,7 +202,7 @@ icons--create
:height (if (eq height 'line)
(window-default-line-height)
height)
- :scale 1)
+ :scale 1 :ascent 'center)
(create-image file))))))
(cl-defmethod icons--create ((_type (eql 'emoji)) icon _keywords)
diff --git a/lisp/outline.el b/lisp/outline.el
index b19e0cf811..364c3bee84 100644
--- a/lisp/outline.el
+++ b/lisp/outline.el
@@ -292,16 +295,18 @@ outline-minor-mode-use-buttons
:safe #'booleanp
:version "29.1")
-(define-icon outline-open button
- '((emoji "🔽")
+(define-icon outline-open nil
+ '((image "outline-open.svg" :height 15 :ascent center)
+ (emoji "🔽")
(symbol " ▼ ")
(text " open "))
"Icon used for buttons for opening a section in outline buffers."
:version "29.1"
:help-echo "Open this section")
-(define-icon outline-close button
- '((emoji "▶️")
+(define-icon outline-close nil
+ '((image "outline-close.svg" :height 15 :ascent center)
+ (emoji "▶️")
(symbol " ▶ ")
(text " close "))
"Icon used for buttons for closing a section in outline buffers."
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/14
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/15
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/15
- bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/15
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/15
- bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/15
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/15
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/16
bug#57813: Icon images are non-functional,
Juri Linkov <=
- bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/16
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/16
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/17
- bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/18
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/18
bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/18
bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/18
bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/19
bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/19
bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/20