bug#58010: 29.0.50; gnus: wrong score file is used

[Sam Steingold]

I noticed that an article was scored wrongly, so I did `V t`
and discovered that the rule comes from the file "soc" that is not
intended for this group.

Playing with the settings revealed the culprit:

--8<---------------cut here---------------start------------->8---
(add-hook 'gnus-score-find-score-files-function 'sds-gnus-upscore-new-thread)
(defun sds-gnus-upscore-new-thread (group)
  "Up-score thread-starters in all groups with _discussions_.
Exclude `news` groups where there are no threads."
  (and (not (string-match (concat "\\." (regexp-opt '("news" "slashdot" 
"announce" "stackexchange" "stackoverflow" "ru.org." "reddit"))) group))
       '("new-thread")))
--8<---------------cut here---------------end--------------->8---

when I remove `sds-gnus-upscore-new-thread' from
`gnus-score-find-score-files-function', the scores are correct (minus
"new-thread" - which is, correctly, _not_ applied), but when I do add
`sds-gnus-upscore-new-thread' to `gnus-score-find-score-files-function',
I get _both_ "new-thread" and "soc" rules (and no, these files do not
reference each other)

`gnus-newsgroup-name' is "gmane.emacs.devel" and
--8<---------------cut here---------------start------------->8---
(sds-gnus-upscore-new-thread gnus-newsgroup-name)
==> ("/Users/sdsg/home/.gnus-kill/new-thread")
--8<---------------cut here---------------end--------------->8---
HUH?! how come the return name is expanded?!
Okay, I re-evaled the defun and got the expected ("new-thread").
Moreover, when I re-enter "gmane.emacs.devel", I get correct scoring
("new-thread" is on but "soc" is off).
Good? Nope!
Now I enter "gwene.com.ycombinator.news" and I get
"new-thread" applied:
--8<---------------cut here---------------start------------->8---
("" 10 nil e) [new-thread] -> ~/home/.gnus-kill/new-thread

Total score: 10
--8<---------------cut here---------------end--------------->8---
even though
--8<---------------cut here---------------start------------->8---
(sds-gnus-upscore-new-thread gnus-newsgroup-name)
==> nil
--8<---------------cut here---------------end--------------->8---

Thank you.
-Sam





In GNU Emacs 29.0.50 (build 5, x86_64-apple-darwin21.6.0, NS
 appkit-2113.60 Version 12.5.1 (Build 21G83)) of 2022-09-19 built on
 3c22fb11fdab.ant.amazon.com
Repository revision: ba0e989c11ebe05bb519845a6d3ab5af1e2715d8
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.6

Configured using:
 'configure --with-imagemagick --with-mailutils --with-ns
 PKG_CONFIG_PATH='

Configured features:
ACL GIF GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
KQUEUE NS PDUMPER PNG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP ZLIB

Important settings:
  value of $LANG: C
  locale-coding-system: utf-8-unix

Major mode: Score

Minor modes in effect:
  pyvenv-mode: t
  shell-dirtrack-mode: t
  global-edit-server-edit-mode: t
  winner-mode: t
  which-function-mode: t
  url-handler-mode: t
  desktop-save-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  column-number-mode: t
  line-number-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  abbrev-mode: t

Load-path shadows:
None found.

Features:
(gnus-cus gnus-demon gnus-diary nndiary gnus-draft gnus-html gnus-kill
gnus-logic gnus-mh mh-comp mh-scan mh-gnus mh-e mh-buffers mh-loaddefs
gnus-registry registry rmailsum rmail gnus-salt gnus-topic gnus-vm
gnus-fun log-edit ein-jupyter ein-dev ein-notebook ein-python-send
ein-traceback ein-pytools ein-pager ein-completer ein-notification
ein-scratchsheet ein-worksheet poly-ein quail polymode poly-lock
polymode-base polymode-weave polymode-export polymode-compat
polymode-methods polymode-core polymode-classes eieio-custom eieio-base
ein-kill-ring ein-cell ein-shared-output ein-output-area ein-kernelinfo
ein-kernel ein-ipdb ein-events ein-websocket websocket bindat ein-file
ein-node ein-notebooklist shortdoc ein-contents-api ein-query ein-log
ein-classes ein-core request autorevert anaphora ein-utils deferred dash
ein arc-mode archive-mode clhs smerge-mode diff cal-move face-remap
color facemenu dabbrev tramp-cmds vc-src vc-sccs vc-svn vc-cvs vc-rcs
log-view pcvs-util shadow emacsbug skeleton apropos smtpmail rot13
bbdb-message mailalias cookie1 flow-fill misearch multi-isearch sort
smiley gnus-cite nndoc textsec uni-scripts idna-mapping uni-confusable
textsec-check gnus-bcklg gnus-async gnus-dup qp mail-extr gnus-ml
hl-line disp-table spam spam-stat gnus-uu yenc nndraft nnmh gnus-agent
gnus-srvr gnus-score score-mode nnvirtual gnus-msg utf-7 gnus-cache
bbdb-gnus nntp cl-print time mm-archive network-stream url-cache
url-http url-auth url-gw nsm display-line-numbers finder-inf package
add-log vc-hg vc-bzr tramp-cache time-stamp tramp-sh tramp
tramp-loaddefs trampver tramp-integration tramp-compat ls-lisp remember
cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine
cc-vars cc-defs sh-script smie executable company-oddmuse
company-keywords company-etags company-gtags company-dabbrev-code
company-dabbrev company-files company-clang company-template
company-cmake company-bbdb yasnippet-snippets yasnippet flymake-proc
flymake company-capf company help-fns radix-tree elpy elpy-rpc pyvenv
eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module
esh-groups esh-util elpy-shell elpy-profile elpy-django s elpy-refactor
ido hideshow grep files-x etags fileloop xref cus-edit pp cus-start
python project compat compat-macs tex-mode compile shell flyspell ispell
display-fill-column-indicator org-element avl-tree generator cl-extra
ol-eww eww url-queue thingatpt mm-url ol-rmail ol-mhe ol-irc ol-info
ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls
dig gnus-sum shr pixel-fill kinsoku url-file svg dom browse-url url
url-proxy url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util gnus-group gnus-undo gnus-start
gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo
parse-time gnus-spec gnus-int gnus-range message sendmail mailcap
yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums gmm-utils mailheader gnus-win ol-docview doc-view filenotify
jka-compr image-mode wallpaper xdg exif ol-bibtex ol-bbdb ol-w3m ol-doi
org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete pcomplete comint osc
ansi-color org-list org-faces org-entities noutline outline org-version
ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex iso8601 ol rx
org-keys oc org-compat org-macs org-loaddefs format-spec cal-x view
cal-china cal-bahai cal-islam holidays holiday-loaddefs bbdb-anniv
cal-iso cal-hebrew lunar cal-julian solar cal-dst appt diary-lib
diary-loaddefs cal-menu calendar cal-loaddefs bug-reference vc-git
diff-mode easy-mmode vc-dir ewoc vc vc-dispatcher dired-aux dired
dired-loaddefs midnight warnings icons gnus nnheader gnus-util
text-property-search time-date mail-utils range mm-util mail-prsvr
wid-edit bbdb-mua bbdb-com crm mailabbrev bbdb bbdb-site timezone
modus-vivendi-theme modus-themes pcase edit-server advice server winner
ring which-func imenu edebug debug backtrace help-mode find-func
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv
url-vars help-at-pt desktop frameset cl-loaddefs cl-lib cus-load info
bbdb-autoloads edit-server-autoloads ein-autoloads elpy-autoloads
company-autoloads fb2-reader-autoloads async-autoloads f-autoloads
dash-autoloads markdown-mode-autoloads polymode-autoloads
request-autoloads s-autoloads websearch-autoloads with-editor-autoloads
compat-autoloads yaml-mode-autoloads yasnippet-snippets-autoloads rmc
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads kqueue
cocoa ns lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 2549605 199509)
 (symbols 48 51383 26)
 (strings 32 486987 16050)
 (string-bytes 1 14548412)
 (vectors 16 160252)
 (vector-slots 8 2989737 336684)
 (floats 8 1374 1117)
 (intervals 56 217758 7269)
 (buffers 1000 132))

-- 
Sam Steingold (https://aphar.dreamwidth.org/) on darwin Ns 10.3.2113
https://lastingimpactpsychology.com https://steingoldpsychology.com
http://think-israel.org https://iris.org.il https://ffii.org
If a horse tells you that you are mad, it is probably right.