From 1e59ff312115290d4ec60adb5c8f0def613d4634 Mon Sep 17 00:00:00 2001 From: Jim Porter Date: Wed, 28 Sep 2022 09:34:38 -0700 Subject: [PATCH 2/5] ; Obsolete 'eshell/define' * lisp/eshell/esh-var.el (eshell/define): Make obsolete, and explain its current state. * doc/misc/eshell.texi (Built-ins): Remove 'define'. --- doc/misc/eshell.texi | 5 ----- lisp/eshell/esh-var.el | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/misc/eshell.texi b/doc/misc/eshell.texi index 0ee33f2c2a..8036bbd83a 100644 --- a/doc/misc/eshell.texi +++ b/doc/misc/eshell.texi @@ -439,11 +439,6 @@ Built-ins is similar to, but slightly different from, the GNU Coreutils @command{date} command. -@item define -@cmindex define -Define a variable alias. -@xref{Variable Aliases, , , elisp, The Emacs Lisp Reference Manual}. - @item diff @cmindex diff Compare files using Emacs's internal @code{diff} (not to be confused diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el index 36e59cd5a4..3c09fc52fb 100644 --- a/lisp/eshell/esh-var.el +++ b/lisp/eshell/esh-var.el @@ -302,6 +302,11 @@ eshell-interpolate-variable (defun eshell/define (var-alias definition) "Define a VAR-ALIAS using DEFINITION." + ;; FIXME: This function doesn't work (it produces variable aliases + ;; in a form not recognized by other parts of the code), and likely + ;; hasn't worked since before its introduction into Emacs. It + ;; should either be removed or fixed up. + (declare (obsolete nil "29.1")) (if (not definition) (setq eshell-variable-aliases-list (delq (assoc var-alias eshell-variable-aliases-list) -- 2.25.1