[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60758: 29.0.60; while-let uses if-let* convention in contradiction t
From: |
Sean Whitton |
Subject: |
bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring |
Date: |
Thu, 12 Jan 2023 17:37:35 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello,
On Thu 12 Jan 2023 at 08:21PM +01, Daniel Mendler wrote:
> The docstring of `while-let' says:
>
> The variable list SPEC is the same as in if-let.
>
> However in the definition `if-let*' is used. `if-let*' differs from
> `if-let' since it doesn't support the special single binding form.
>
> (while-let (var exp)
> ...)
>
> Therefore `if-let*' should be replaced with `if-let' in the definition
> of `while-let', bringing the implementation in accordance with the
> docstring. The name `while-let' (in contrast to `while-let*') also
> suggest that the `if-let' spec is supported.
I agree that if-let is right, for these reasons. Now fixed, thank you.
--
Sean Whitton
- bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring, Daniel Mendler, 2023/01/12
- bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring,
Sean Whitton <=
- bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring, Sean Whitton, 2023/01/14
- bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring, Eli Zaretskii, 2023/01/14
- bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring, Sean Whitton, 2023/01/14
- bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring, Michael Heerdegen, 2023/01/14
- bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring, Eli Zaretskii, 2023/01/15