[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60897: 29.0.60; vc-revert fails to revert buffer
From: |
Juri Linkov |
Subject: |
bug#60897: 29.0.60; vc-revert fails to revert buffer |
Date: |
Mon, 23 Jan 2023 09:51:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>> > (defun vc-resynch-buffer (file &optional keep noquery reset-vc-info)
>> > "If FILE is currently visited, resynch its buffer."
>> > + (unless (file-name-absolute-p file)
>> > + (setq file (expand-file-name file (vc-root-dir))))
>> > (if (string= buffer-file-name file)
>> > (vc-resynch-window file keep noquery reset-vc-info)
>> > (if (file-directory-p file)
>>
>> Eli, is this ok for the emacs-29 branch? I'm unsure because
>> vc-resynch-buffer is used in too many places, so this change
>> is not localized to vc-revert.
>
> You could use the expanded file name only for the purposes of the
> string= call, no? Then the effect of this change would be very local
> and thus safer.
There is another string= call that fails inside vc-resynch-window
called from vc-resynch-buffer.
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Eric Gillespie, 2023/01/17
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Juri Linkov, 2023/01/18
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Eric Gillespie, 2023/01/20
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Juri Linkov, 2023/01/22
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Eli Zaretskii, 2023/01/22
- bug#60897: 29.0.60; vc-revert fails to revert buffer,
Juri Linkov <=
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Eli Zaretskii, 2023/01/23
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Juri Linkov, 2023/01/24
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Eli Zaretskii, 2023/01/24
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Juri Linkov, 2023/01/24
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Eli Zaretskii, 2023/01/24
- bug#60897: 29.0.60; vc-revert fails to revert buffer, Juri Linkov, 2023/01/24