[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61069: 30.0.50; comint-copy-old-input should include continuation li
From: |
Bob Rogers |
Subject: |
bug#61069: 30.0.50; comint-copy-old-input should include continuation lines |
Date: |
Wed, 25 Jan 2023 17:43:02 -0800 |
In a shell-mode buffer with lots of "make" output, there will often
appear commands with continuation lines. To use them as new input
(e.g. while debugging some bit of makefile logic) requires either
marking and copying multiple lines, or multiple invocations of
comint-copy-old-input (C-RET in shell-mode) to get the complete command.
The attached patch against f0971f94fe42224b4d85bb8b6188d5d805689ddf in
master includes those continuation lines, which seems like a desirable
bit of dwimmery. However, I may have misunderstood the purpose of the
line-end-position vs. field-end thing. Also, this assumes shell syntax,
so it may be more appropriate to leave comint-get-old-input-default
alone and give shell-mode its own shell-get-old-input-default function.
-- Bob Rogers
http://www.rgrjr.com/
diff --git a/lisp/comint.el b/lisp/comint.el
index c5589324a14..89c35149022 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -2377,7 +2377,7 @@ comint-get-old-input-default
"Default for `comint-get-old-input'.
If `comint-use-prompt-regexp' is nil, then either
return the current input field, if point is on an input field, or the
-current line, if point is on an output field.
+current line, with continuation lines, if point is on an output field.
If `comint-use-prompt-regexp' is non-nil, then return
the current line with any initial string matching the regexp
`comint-prompt-regexp' removed."
@@ -2388,11 +2388,18 @@ comint-get-old-input-default
(setq bof (field-beginning)) 'field))))
(field-string-no-properties bof)
(comint-bol)
- (buffer-substring-no-properties (point)
- (if (or comint-use-prompt-regexp
- (eq field-prop 'output))
- (line-end-position)
- (field-end))))))
+ (let ((start (point)))
+ (cond ((or comint-use-prompt-regexp
+ (eq field-prop 'output))
+ (goto-char (line-end-position))
+ ;; Include continuation lines as long as the current
+ ;; line ends with a backslash.
+ (while (and (not (eobp))
+ (= (char-before) ?\\))
+ (goto-char (line-end-position 2))))
+ (t
+ (goto-char (field-end))))
+ (buffer-substring-no-properties start (point))))))
(defun comint-copy-old-input ()
"Insert after prompt old input at point as new input to be edited.
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines,
Bob Rogers <=
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Eli Zaretskii, 2023/01/26
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Bob Rogers, 2023/01/26
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Eli Zaretskii, 2023/01/26
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Bob Rogers, 2023/01/26
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Eli Zaretskii, 2023/01/26
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Bob Rogers, 2023/01/27
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Robert Pluim, 2023/01/30
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Bob Rogers, 2023/01/30
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Bob Rogers, 2023/01/30
- bug#61069: 30.0.50; comint-copy-old-input should include continuation lines, Robert Pluim, 2023/01/31