[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less s
From: |
Stefan Monnier |
Subject: |
bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict |
Date: |
Mon, 30 Jan 2023 16:00:51 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> In patch f67a9a12b7b0cdd6030cb080a6d6838255789a08, the commands
> keymap-local-set and keymap-global-set became less strict for
> non-interactive use, which is not the intended the design. The goal is
> that the API only accepts strings in a single format. The vector to
> string conversion should happen within the interactive form.
I don't see any use for the vector->string conversion to happen in the
interactive spec: I think the most important use cases for accepting
vectors is when these come directly from Lisp, in which case having to
convert them back to the KBD syntax (only to hope `key-parse` will
correctly undo the damage) is just a waste and a hurdle.
> There was an old commit by Stefan Monnier, where he relaxed the API, but
> Lars made it clear back then that it is better to only accept a single
> format for the keymap API, such that guidance for the user is better due
> to clear error messages.
Obviously, I disagree: the vector format is not going anywhere, so it
makes a lot sense to accept it, even though I fully agree that guidance
should never suggest the use of the vector format.
Stefan
- bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict, Daniel Mendler, 2023/01/30
- bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict,
Stefan Monnier <=
- bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict, Lars Ingebrigtsen, 2023/01/30
- Message not available
- Message not available
- bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict, Robert Pluim, 2023/01/31
- bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict, Stephen Berman, 2023/01/31
- bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict, Robert Pluim, 2023/01/31
- bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict, Stephen Berman, 2023/01/31
- bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict, Eli Zaretskii, 2023/01/31
bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict, Eli Zaretskii, 2023/01/31