bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#61221: 30.0.50; [PATCH] Support completion of quoted variable refs i


From: Jim Porter
Subject: bug#61221: 30.0.50; [PATCH] Support completion of quoted variable refs in Eshell
Date: Thu, 23 Feb 2023 15:17:35 -0800

On 2/23/2023 2:39 PM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote:
As I understand it, returning 't' means "there is just one matching
completion, and the match is exact"[1], but in this case, that's not really
  true: after completing "~user/" there are still more matching completions
(the contents of the user's home directory).

What you describe is for `try-completion`, not `test-completion`.

This is really just trying to match what happens when calling
'completion-file-name-table':

   (completion-file-name-table "~user/" nil nil)
     => "~user/"

   (try-completion "~user/" '("~user/") nil)
     => t

The `action` arg is not `lambda` is these examples.

Ohhh. I totally missed that part. Pushed a fix as 0a361fd91a. Thanks again for finding my mistakes.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]