[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'
From: |
Visuwesh |
Subject: |
bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' |
Date: |
Fri, 03 Mar 2023 07:58:07 +0530 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
[வியாழன் மார்ச் 02, 2023] Manuel Giraud via "Bug reports for GNU Emacs, the
Swiss army knife of text editors" wrote:
> Manuel Giraud <manuel@ledu-giraud.fr> writes:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> [...]
>>
>>> You are right, of course. It just feels strange to need to cater to
>>> themes in a core package, when the way themes are supposed to
>>> customize Emacs exists and can be used in this case as well.
>>>
>>> Alternatively, maybe themes should have settings for features such as
>>> this one?
>>
>> Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the
>> official Emacs themes for a start, WDYT?
>
> ... and in order to be able to use 'custom-theme-set-faces', we could
> have a 'doc-view-svg-face' (used only for its foreground and
> background). I'm caching you up slowly 😅
Themes can also use `custom-theme-set-variables' so I did not see a need
to introduce a face when I made the patch back then.
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme', Eli Zaretskii, 2023/03/02
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme', Manuel Giraud, 2023/03/02
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme', Eli Zaretskii, 2023/03/02
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme', Manuel Giraud, 2023/03/02
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme', Eli Zaretskii, 2023/03/02
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme', Manuel Giraud, 2023/03/02
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme', Eli Zaretskii, 2023/03/09
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme',
Visuwesh <=
- bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme', Eli Zaretskii, 2023/03/03