[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62435: [PATCH] 29.0 Fix eww--download-directory on MS-Windows
From: |
lux |
Subject: |
bug#62435: [PATCH] 29.0 Fix eww--download-directory on MS-Windows |
Date: |
Sat, 25 Mar 2023 22:17:01 +0800 |
User-agent: |
Evolution 3.46.4 (3.46.4-1.fc37) |
On Sat, 2023-03-25 at 17:05 +0300, Eli Zaretskii wrote:
> > From: lux <lx@shellcodes.org>
> > Cc: 62435@debbugs.gnu.org
> > Date: Sat, 25 Mar 2023 21:42:44 +0800
> >
> >
> > +(defcustom eww-default-download-directory "~/Downloads/"
> > + "The default directory where downloaded files will be saved."
> > + :version "29.0"
> ^^^^^^
> This should be "30.1".
>
> > (defun eww--download-directory ()
> > "Return the name of the download directory.
> > If ~/Downloads/ exists, that will be used, and if not, the
> > DOWNLOAD XDG user directory will be returned. If that's
> > undefined, ~/Downloads/ is returned anyway."
> > - (or (and (file-exists-p "~/Downloads/")
> > - "~/Downloads/")
> > + (or (and (file-exists-p eww-default-download-directory)
> > + eww-default-download-directory)
> > (when-let ((dir (xdg-user-dir "DOWNLOAD")))
> > (file-name-as-directory dir))
> > - "~/Downloads/"))
> > + eww-default-download-directory))
>
> Please update the doc string as well.
>
>
Done, please review, thank you.
0001-Add-eww-default-download-directory.patch
Description: Text Data