[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62573: 29.0.60; Cursor color not being inverted in emacs-29
From: |
Daniel Martín |
Subject: |
bug#62573: 29.0.60; Cursor color not being inverted in emacs-29 |
Date: |
Thu, 06 Apr 2023 12:12:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) |
Po Lu <luangruo@yahoo.com> writes:
> Daniel Martín <mardani29@yahoo.es> writes:
>
>> +#define CG_SET_FILL_COLOR_WITH_FRAME_CURSOR(context, frame) \
>> + do { \
>> + CGColorRef refcol_ = \
>> + get_cgcolor_from_nscolor (FRAME_CURSOR_COLOR (frame), frame); \
>> + CGContextSetFillColorWithColor (context, refcol_); \
>> + CGColorRelease (refcol_); \
>> + } while (0)
>> +#define CG_SET_FILL_COLOR_WITH_FRAME_BACKGROUND(context, frame) \
>> + do { \
>> + CGColorRef refcol_ = \
>> + get_cgcolor_from_nscolor (FRAME_BACKGROUND_COLOR (frame), frame); \
>> + CGContextSetFillColorWithColor (context, refcol_); \
>> + CGColorRelease (refcol_); \
>> + } while (0)
>
> Thanks. The GNU Coding Standards split expressions, before operators.
> So this should read:
>
> do {
> CGColorRef refcol
> = ...
>
> also, since you put this in a separate block, you don't have to worry
> about shadowing, so there's no need to use names with a trailing
> underscore.
>
OK, I've removed the trailing underscore in the other macros as well.
Here's a new patch with the requested changes. If everything looks
good, could someone install the patch for me? (I don't have push access
to the repository.)
Thanks.
0001-Change-cursor-color-on-NS-port-when-it-matches-the-f.patch
Description: Text Data
bug#62573: 29.0.60; Cursor color not being inverted in emacs-29, Eli Zaretskii, 2023/04/02
bug#62573: 29.0.60; Cursor color not being inverted in emacs-29, Daniel Martín, 2023/04/02
bug#62573: 29.0.60; Cursor color not being inverted in emacs-29, Eli Zaretskii, 2023/04/02
bug#62573: 29.0.60; Cursor color not being inverted in emacs-29, Al Haji-Ali, 2023/04/02