bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#62858: 30.0.50; Typo in gdb-mi.el


From: Eli Zaretskii
Subject: bug#62858: 30.0.50; Typo in gdb-mi.el
Date: Tue, 18 Apr 2023 14:37:40 +0300

> Cc: 62858@debbugs.gnu.org
> Date: Sat, 15 Apr 2023 17:14:47 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Sat, 15 Apr 2023 15:14:35 +0200
> > From:  Manuel Giraud via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> > 
> > I do not think that it generates a bug but while browsing "gdb-mi.el", I
> > noticed the following at line 2409:
> > --8<---------------cut here---------------start------------->8---
> >     ("=" . (("thread-created" . (gdb-thread-created . atomic))
> >             ("thread-selected" . (gdb-thread-selected . atomic))
> >             ("thread-existed" . (gdb-ignored-notification . atomic))
> > --8<---------------cut here---------------end--------------->8---
> > 
> > Should it not be "thread-exited"?  There is no reference to
> > "thread-existed" in the GDB info.
> 
> You are right.  But I think the snafu here is even more than just a
> typo.  This code was introduced in commit 6ff2c8f1f, where Stefan
> (CC'ed) took a patch by Jean-Philippe Gravel and improved it.  But as
> part of that change, Stefan made this typo, and also made
> gdb-thread-exited a function that no one calls, which was not what
> happened with the original code.
> 
> So I think we need to fix that with the patch below.
> 
> Stefan, any comments?

No more comments, so I've now installed the patch on the emacs-29
branch, and I'm therefore closing this bug.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]