bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#62696: python.el: Extra indentation for conditionals


From: kobarity
Subject: bug#62696: python.el: Extra indentation for conditionals
Date: Thu, 20 Apr 2023 23:19:51 +0900
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Gojō) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Gustaf Waldemarson wrote:
> It mostly looks good to me, but perhaps it would make sense to still output
> the closing paren on the same line as the first example? I suppose it might
> not make sense from a style-perspective, but I guess someone reading through
> this mostly care about comparing indentation depths

Do you mean

    def do_something(
        arg1,
        arg2):
        print('hello')

is better than the following?

    def do_something(
        arg1,
        arg2
    ):
        print('hello')

If so, I think it is still good.  I updated the patches.

> > Do these two patches replace every other patch posted in this
> > discussion?
> > Are these two patches ready to be installed, or are you still
> > discussing the issue?
> 
> I believe that's the case, but I would wait for a response from Kobarity
> following this.

Yes, I'm attaching the patches which replace every other patches in
old mails.  I was just waiting to see if anyone had any comments or
feedback.  So, unless there is an objection, the patches are ready to
be installed on the master branch.

Attachment: 0001-Add-a-new-user-option-in-Python-mode-to-improve-the-.patch
Description: Binary data

Attachment: 0002-Improve-docstring-of-python-indent-def-block-scale.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]