bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown


From: João Távora
Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown
Date: Mon, 27 May 2024 22:05:28 +0100

On Mon, May 27, 2024 at 6:35 PM Felician Nemeth
<felician.nemeth@gmail.com> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> >> > So when e-m-m-hook was added it was made to run only on "turn on"
> >>
> > IOW, I don't think there was ever a time when it was ever run at "off"
> > time.
>
> I don't think it matters much, but originally it did run in both cases:
> https://github.com/joaotavora/eglot/commit/8d8c90d0d654d262e0ff43f45444ec6a512b8185
>
> So the current situation can be regarded as a regression.

I think it does matter, it's one less thing to worry about if we
push that one-liner patch.  Can you comment on it, is it doing
more or less the same in your opinion?  I opted to put it before
before the server is shutdown, so that, like the on case, it has
access to a presumably fully setup server.

João





reply via email to

[Prev in Thread] Current Thread [Next in Thread]