[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [patch #5244] Clean up DATA LIST and PRINT

From: Ben Pfaff
Subject: PSPP-BUG: [patch #5244] Clean up DATA LIST and PRINT
Date: Mon, 17 Jul 2006 07:23:56 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20060406 Firefox/ (Debian-1.5.dfsg+

Follow-up Comment #2, patch #5244 (project pspp):

> I'm still not 100% happy with the way that messages are handled. I think
> be necessary to have a system that can selectively disable messages, based
> message ID and destination.

Well, there's what I intend msg_disable/msg_enable to be used for, which is
to disable messages from specific functions as an alternative to passing in a
"emit_messages" flag to that function, and then there's what it *can* be used
for, which is to disable any message anytime.  I like having them for the
former purpose, because it's inconvenient to write those functions so that
they check the flag before emitting any message, and most callers *do* want
the messages in practice.

I'm not trying to preempt a broader discussion with this patch.  If you like,
I'll prepare a new version that avoids adding msg_disable/msg_enable in favor
of passing flags, and then we can bring up the broader discussion again.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]