Re: Binutils bug

[Nick Clifton]

Hi Mayan,

: Symptom:
: ar crashes when built for rs6000-ibm-aix target on i586-pc-cygwin host
: 
: Fix:
: replace line 811 of bfd/rs6000-coff.c
: 
: #define xcoff_big_format_p(abfd) \
:   (xcoff_ardata (abfd)->magic[1] == 'b' )
: 
: with
: 
: #define xcoff_big_format_p(abfd) \
:   (xcoff_ardata (abfd) != NULL || xcoff_ardata (abfd)->magic[1] == 'b' )

This is not a good idea, since the code will now think that the
particular archive element file is little-endian, when in fact the
endianism is not known.

A better solution would be to add checked before xcoff_big_format_p is
used to see if the archive data actually exists and to generate some
kind of appropriate error if it does not.

Cheers
        Nick