[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug in gas
From: |
Nick Clifton |
Subject: |
Re: Bug in gas |
Date: |
Thu, 30 Nov 2000 10:19:43 -0800 |
Hi Greg,
: I found a bug in gas in the file app.c. I am using an avr target
: compiled on a linux host. The bug is that line separators in an
: assembly source file do not work. A patch to fix this is:
:
: --- binutils-2.9.5.0.13/gas/app.c Mon Jul 19 09:46:51 1999
: +++ binutils-2.9.5.0.13.save/gas/app.c Thu May 11 20:31:28 2000
: @@ -989,7 +989,7 @@
:
: case LEX_IS_LINE_SEPARATOR:
: state = 0;
: - PUT (ch);
: + PUT ('\n');
: break;
This does not look right. 'ch' is the character that has the
LEX_IS_LINE_SEPERATOR attribute, whereas there is no guarantee that
'\n' is a line separator on all targets. Thus emitting 'ch' ought to
be the right thing to do.
Do you have a test case that reproduces this problem ?
: Content-Disposition: attachment;
filename="binutils-2.9.5.0.13-avr-patch-1.1.gz"
Why did you attach this file ?
Cheers
Nick
- Bug in gas, gpgreen, 2000/11/30
- Re: Bug in gas,
Nick Clifton <=