Re: Some grep 2.5e issues

[Alain Magloire]

Bonjour

> Hi,
> I've just tried out grep 2.5e (on a post-7.1 snapshot of Red Hat Linux).

hmm .. ok.  Although the alpha/beta stuff on alpha.gnu.org/gnu/grep/* where not
meant  to be actuall releases(production environment) but rather snapshots
of the CVS repository at different "stable" stage:

$ cvs -d :pserver:address@hidden:/cvs login
Password: [just hit enter]
$ cvs -d :pserver:address@hidden:/cvs checkout grep 

> There are a couple of things that should IMO be changed:
> 
> 1. PCRE detection isn't working right. Red Hat Linux (and probably others)
>    place pcre.h in /usr/include/pcre rather than straight /usr/include
>    (or /usr/local/include); grep doesn't catch this.
>    Since PCRE comes with pcre-config (that takes care of just that), it's
>    simple to fix; Patch attached as attachment #1

Noted.

> 2. Since some people will definitely alias grep="grep --color" sooner or
>    later (and start wondering why the output of "grep foo /bar |less"
>    looks weird), I think --color should be handled the way it is in ls:
>    Allow an optional parameter (--color={never,always,auto}) and default
>    to --color=auto if the user specifies just "--color".
>    Patch attached as attachment #2 (includes patch to docs)

Yes, I've been meaning to correct that, I will on the next beta.

> 3. This is a matter of taste, but I think the blinking of grep --color
>    output is not a very good idea; Attachment #3 switches this over to
>    "normal" red.

Sounds good.

> 4. README-alpha states "This is a test release of GNU tar" and tells
>    people to report bugs to bugs-tar. I don't presume that's a feature. ;)
>    Fixed by attachment #4

8-) Ho no!! busted.
Already fix in repository.

> Other than that, it seems to work really well.

Ok, thanks for taking the time to test this, I will process your patches
later this week.

--
alain