New i18n bug with ld

[Christian Rose]

While translating ld 2.12-pre020121 into Swedish, I have encountered one
message from the source that is problematic with regard to
internationalization.


BUG
---
ldmain.c:334

      info_msg (_("using %s linker script:\n"),
                saved_script_handle ? "external" : "internal");

This is broken. Don't split up a sentence like this, use multiple full
messages instead. There are many problems with split-ups like this. One
of the most serious is that you assume things about other languages that
are not necessarily true. In this case you assume that the words
"external" and "internal" (adjectives) can be independantly translated
from their substantive (linker script), which isn't necessarily true. So
this design would be broken even if the words "external" and "internal"
had even been marked for translation.

The moral is: use full sentences.

My suggestion:

if (saved_script_handle) {
      info_msg (_("using external linker script:\n"));
} else {
      info_msg (_("using internal linker script:\n"));
}


Christian