Re: Makefile.in.in improvement

[Jim Meyering]

Bruno Haible <address@hidden> wrote:
> Jim Meyering writes:
>
>> The first just factors out some duplication.
>
> Thanks, but I don't think this patch makes the Makefile easier to
> understand.

Hi Bruno,

The point is not merely to make it easier to understand.  It is also
to make it more maintainable.  Since the command was originally in two
places (echoed in one place and executed in the other), and since I had
to change it to make the rule more robust, it is better to factor it so
that the next time someone has to change it, they have only one thing
to change, not two that they may or may not keep in synch.

>> The second is more important in that it prevents
>> a failure of msgfmt or gmsgfmt from resulting in
>> corrupt Makefile targets.
>
> I don't see the point of this patch because nothing in the
> Makefile.in.in uses this .po.mo rule. But anyway, it makes it more
> robust. Thanks, applied.

If the .po.mo rule is not used, then shouldn't you remove it?
I noticed the problem on the .po.gmo rule.

Jim