Re: about gawk |& operator and getline on HPUX11

[Stepan Kasal]

Hallo Aharon,
        Zhao Xiang <address@hidden> has discovered the cause
of the bug they reported earlier.  When they explained the reasons to
me, I've created gawk-3.1.1-optimal_bufsize_check.patch
(it's attached to this message).  It checks the value of
stb->st_blksize, and supplies BUFSIZ if the value is suspicious.

As far as I understand the problem, HP-UX 11 with unpatched fstat()
could have told us any value of stb->st_blksize, not only that negative
value that was mentioned in the bug report. And there is a possibility
that similar bug appears elsewhere.

I suggest that the first one of the two patches I posted on Wednesday,
gawk-3.1.1-optimal_bufsize_size_t.patch, gets to the main tree together
with this patch.  The *size_t.patch does not fix any bug, but I think
it's right to have the return value of function optimal_bufsize() typed
as size_t, anyway.

The above mentioned combination of the two patches was tested
on HP-UX 11 by Zhao Xiang and on Linux/i386 by me.

I'd like to thank again to Zhao Xiang for all her/his help.

With best regards,
        Stepan Kasal

gawk-3.1.1-optimal_bufsize_check.patch
Description: Text document