[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Don't cast to int, but to long

From: Bruno Haible
Subject: Re: [PATCH] Don't cast to int, but to long
Date: Thu, 7 Apr 2005 14:10:14 +0200
User-agent: KMail/1.5

Andreas Schwab wrote:
> Even better, just remove these broken casts.

Removing the casts, yes. Thanks. But using
   (gettext ("") != 0)
in an AC_TRY_LINK is not future-proof: gcc already knows that some functions
like strchr() want a non-NULL pointer as argument. In the near future, gcc
may also know that gettext() always returns a non-NULL result and optimize
   (gettext ("") != 0)
to 'true', thus annihilating the purpose of the AC_TRY_LINK.

   * gettext ("")
seems safer to me.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]