Re: address@hidden: [PATCH] sharutils-4.3.80: configure.ac tweak to build uuencode/uudecode OOTB on Cygwin]

[Corinna Vinschen]

On Jun  8 06:48, Bruce Korb wrote:
> Hi, guys, I did not notice the switch to single quotes.
> Single quotes pass through the '$(XXX)' construct.
> I was thinking "shell script" instead of "makefile script",
> since "configure.ac" is the direct predecessor to a script.
> It seems more flexible to fully evaluate "ADD_PROG" in
> the configure script anyway, so I'll leave it as:
> 
> > > > > +  ADD_PROG="uudecode${EXEEXT} uuencode${EXEEXT}"
> 
> (thus curly braces are required....)  That leaves @ADD_PROG@
> usable in a configurable shell script, too.  (Were one ever to
> do that...)
> 
> Thanks again :) - Bruce

Well... it's ok with me, but it's also somewhat unclean, IMHO.

The resulting Makefile contains this on, say, GNU/Linux:

  $ grep '^bin_PROGRAMS' src/Makefile
  bin_PROGRAMS = shar$(EXEEXT) unshar$(EXEEXT) uudecode uuencode

and this on Cygwin:

  $ grep '^bin_PROGRAMS' src/Makefile
  bin_PROGRAMS = shar$(EXEEXT) unshar$(EXEEXT) uudecode.exe uuencode.exe

while when using single quotes and parenthesis you get this on all systems:

  $ grep '^bin_PROGRAMS' src/Makefile
  bin_PROGRAMS = shar$(EXEEXT) unshar$(EXEEXT) uudecode$(EXEEXT) 
uuencode$(EXEEXT)


Thanks all the same,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.