[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: locale-dependent assertion failure in gawk 3.1.5

From: Andrew J. Schorr
Subject: Re: locale-dependent assertion failure in gawk 3.1.5
Date: Fri, 7 Jul 2006 18:05:00 -0400
User-agent: Mutt/

On Fri, Jul 07, 2006 at 04:57:28PM -0400, Andrew J. Schorr wrote:
> But this all raises a question of what the canonically proper way
> is to clear the wstptr setting.  Perhaps a macro or function would
> be appropriate...

So does the attached patch make sense?  Or would it be better to
use a macro to avoid the performance hit of a function call?
I think it's a bit cleaner/safer not to repeat the same code
in multiple places...

Given that NODE is a union, I'm not clear on whether it's OK to
test the wstptr value if the WSTRCUR flag is not set.  I guess
one has to assume that wstptr may contain random garbage if WSTRCUR
is not set; is that the correct approach?  Or would it be safe to
assume that if STRCUR is set, then
   (wstptr != NULL) <==> ((flags & WSTRCUR) != 0)?


Attachment: wstptr.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]